[PATCH V2 4/4] b43: HT-PHY: init: init BPHY and upload 0x1a table

Larry Finger Larry.Finger at lwfinger.net
Fri Aug 12 11:36:37 EDT 2011


On 08/12/2011 10:22 AM, Rafał Miłecki wrote:
> W dniu 12 sierpnia 2011 17:16 użytkownik Larry Finger
> <Larry.Finger at lwfinger.net>  napisał:
>> On 08/12/2011 08:27 AM, Rafał Miłecki wrote:
>>>
>>> Signed-off-by: Rafał Miłecki<zajec5 at gmail.com>
>>> ---
>>> BPHY is something partially known from N-PHY.
>>>
>>> This 0x1a table with 0xc0 offset is a little tricky. We already upload
>>> something like that earlier, but this is needed to stop radio going crazy
>>> and transmissint crap.
>>
>> I don't care that the commit message contains "crap", but others might. I
>> do, however, want you to change from the nonexistent "transmissint" to
>> "transmission" or "transmitting", whichever you mean.
>>
>> Other than that, ACK. Note, I have no HT device, thus I have done no
>> testing.
>
> Err, that's comment, not commit message. Won't be visible in "git log".
>
> Should I still change it?

Sorry I missed the ---. In the comment, it is OK.

Larry



More information about the b43-dev mailing list