[RFC][RFT][PATCH V2 2/2] b43: fix DMA on some bugged hardware

Rafał Miłecki zajec5 at gmail.com
Thu Aug 11 12:22:26 EDT 2011


W dniu 11 sierpnia 2011 18:21 użytkownik Rafał Miłecki
<zajec5 at gmail.com> napisał:
> W dniu 11 sierpnia 2011 18:04 użytkownik John W. Linville
> <linville at tuxdriver.com> napisał:
>> On Thu, Aug 11, 2011 at 10:05:19AM +0200, Rafał Miłecki wrote:
>>> W dniu 11 sierpnia 2011 06:39 użytkownik Larry Finger
>>> <Larry.Finger at lwfinger.net> napisał:
>>> > On 08/10/2011 07:14 PM, Rafał Miłecki wrote:
>>> >>
>>> >> W dniu 10 sierpnia 2011 20:35 użytkownik Rafał Miłecki
>>> >> <zajec5 at gmail.com>  napisał:
>>> >>>
>>> >>> Some hardware with 64-bit DMA uses lower address word for setting
>>> >>> routing (translation) bit. Add workaround for such boards.
>>> >>>
>>> >>> Signed-off-by: Rafał Miłecki<zajec5 at gmail.com>
>>> >>> ---
>>> >>> This requires testing on at least 1 normal 64-bit DMA card and 1 32-bit
>>> >>> DMA card. So far it was tested only on my 14e4:4329 where it fixed DMA.
>>> >>
>>> >> 14e4:4353 (BCM43224), 64-bit DMA, still works :)
>>> >>
>>> >> The rest will follow tomorrow.
>>> >
>>> > Tested with 14e4:4311 (64-bit) and 14e4:4318 (32-bit). The ssb changes were
>>> > also tested with b43legacy.
>>>
>>> Thanks Larry.
>>>
>>> I've additionally tested this on 14e4:4312 (BCM4311), 32-bit DMA. Works OK.
>>>
>>> John: please take this patchset.
>>
>> Are these fixes intended for 3.1?
>
> The bug in DMA support is in the driver since the first moment we
> enabled support for N-PHY. It's not any kind of regression. However,
> it's still a bug fix.
>
> If it's OK to take that for 3.1, then go on. I believe it received
> required testing. On the other hand, if it's going to make Dave or
> Linus angry, leave it for 3.2. We have this bug since  2.6.39, we can
> have it for one more release.

s/Dave/David/, sorry

-- 
Rafał



More information about the b43-dev mailing list