[RFC][PATCH] bcmai: introduce AI driver

[Michael Büsch]

On Tue, 2011-04-05 at 22:15 +0200, Rafał Miłecki wrote: 
> Some more reviews, please? Should I drop that prefix, is Joe right?

Yes.

> >> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> > []
> >> +/* AI core, see drivers/bcmai/ */
> >> +struct bcmai_device_id {
> >> +     __u16   manuf;
> >> +     __u16   id;
> >> +     __u8    rev;
> >> +};
> >
> > Do some of these structs need __packed declarations?
> 
> I was reading about __packed long time ago and it was a little tricky
> for me. However I don't see anything in mod_devicetable.h using that
> __packed. Why should we?

I don't think packed is needed here.
Just note that this struct is ABI. So it's written in stone if merged.

-- 
Greetings Michael.