[PATCH 1/3] b43: N-PHY: define channel table struct for rev3+ devices
Larry Finger
Larry.Finger at lwfinger.net
Fri Oct 15 10:53:09 EDT 2010
On 10/15/2010 09:27 AM, Rafał Miłecki wrote:
>
> There is "Chapter 12: Macros, Enums and RTL" in:
> http://www.kernel.org/doc/Documentation/CodingStyle
>
> Some quotes:
> 1) "Macros with multiple statements should be enclosed in a do - while block:"
> 2) "macros defining constants using expressions must enclose the
> expression in parentheses"
>
> Second one may sound like sth close, but it's just about expressions like:
> #define CONSTEXP (CONSTANT | 3)
>
> So there doesn't seem to be any "rule" in CodingStyle wanting us to
> add parentheses when you suggested.
I think that scripts/checkpatch would report any definitions that need parentheses.
As you have probably figured out, I'm back home. If you have spec questions ;),
I'm ready.
Larry
More information about the b43-dev
mailing list