[PATCH 2/3] b43: N-PHY: define registers names for 2056 radio

[Gábor Stefanik]

2010/10/15 Gábor Stefanik <netrolller.3d at gmail.com>:
> 2010/10/15 Rafał Miłecki <zajec5 at gmail.com>:
>> W dniu 15 października 2010 01:58 użytkownik Gábor Stefanik
>> <netrolller.3d at gmail.com> napisał:
>>> 2010/10/14 Rafał Miłecki <zajec5 at gmail.com>:
>>>> Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
>>>> Cc: Henry Ptasinski <henryp at broadcom.com>
>>>> Cc: Brett Rudley <brudley at broadcom.com>
>>>> Cc: Nohee Ko <noheek at broadcom.com>
>>>> ---
>>>>  drivers/net/wireless/b43/radio_2056.h |  522 +++++++++++++++++++++++++++++++++
>>>>  1 files changed, 522 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/net/wireless/b43/radio_2056.h b/drivers/net/wireless/b43/radio_2056.h
>>>> index 60341d7..462c9fd 100644
>>>> --- a/drivers/net/wireless/b43/radio_2056.h
>>>> +++ b/drivers/net/wireless/b43/radio_2056.h
>>>> @@ -4,6 +4,9 @@
>>>>
>>>>   Copyright (c) 2010 Rafał Miłecki <zajec5 at gmail.com>
>>>>
>>>> +  Some parts of the code in this file are derived from the brcm80211
>>>> +  driver  Copyright (c) 2010 Broadcom Corporation
>>>> +
>>>>   This program is free software; you can redistribute it and/or modify
>>>>   it under the terms of the GNU General Public License as published by
>>>>   the Free Software Foundation; either version 2 of the License, or
>>>> @@ -28,6 +31,525 @@
>>>>
>>>>  #include "tables_nphy.h"
>>>>
>>>> +#define RADIO_2056_SYN                         (0x0 << 12)
>>>> +#define RADIO_2056_TX0                         (0x2 << 12)
>>>> +#define RADIO_2056_TX1                         (0x3 << 12)
>>>
>>> Please use B2056_ as the prefix. See LP-PHY.
>>
>> What does it mean? This "B" prefix?
>
> AFAIK it is a contraction for BCM. (The actual radio is called
> BCM2056.) However, LP-PHY already uses B2062_ and B2063_ as its radio
> register prefixes, so it is a good idea to follow the convention here,
> too.

Another reason that just hit me: it allows you to grep for
"b43_phy_read(dev, B20" / "b43_phy_write(dev, B20" to find any
incorrect uses of b43_phy_* ops instead of b43_radio_* ones. (The
initial channel switching problems with LP-PHY were due to my using
b43_phy_* ops in the VCO calibration code!)

>
>>
>> --
>> Rafał
>>
>
>
>
> --
> Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
>



-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)