[PATCH 3/3] b43: N-PHY: add 2055 radio regs

[Gábor Stefanik]

2010/10/11 Rafał Miłecki <zajec5 at gmail.com>:
> W dniu 11 października 2010 18:24 użytkownik Gábor Stefanik
> <netrolller.3d at gmail.com> napisał:
>> Doesn't brcm80211 contain register names for B2055?
>
> Whoops... first of all it's 2056 radio. Commit's message should be
> 2056, not 2055.
>
> Yes, I'm sure we can grab many defines from brcm80211. However before
> copying their code/defines I wanted to finish implementing what we
> have in our RE specs. Is that acceptable? Or should I use brcm80211's
> names if I already touch such places?

I don't know, Michael is the one to decide on this; but in general,
it's bad practice to use magic numbers.

>
> --
> Rafał
>



-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)