[PATCH 3/3] b43: N-PHY: don't duplicate setting channel in shared memory
John W. Linville
linville at tuxdriver.com
Wed Oct 6 16:18:51 EDT 2010
On Wed, Oct 06, 2010 at 06:07:44PM +0200, Rafał Miłecki wrote:
> W dniu 6 października 2010 17:30 użytkownik Michael Büsch
> <mb at bu3sch.de> napisał:
> > On Wed, 2010-10-06 at 07:50 +0200, Rafał Miłecki wrote:
> >> + /* Don't follow specs, B43_SHM_SH_CHAN is set by b43_switch_channel */
> >
> > Looks great. I dunno if a comment is really needed and whether it is
> > correct, though. We _do_ follow the specs. We just do it elsewhere.
>
> I got "Don't strictly follow specs here" earlier, but made it shorter
> to match 80 chars ;) Maybe it wasn't too good idea. Should left it
> longer or don't put at all.
>
> John: could you drop this comment line when applying? Or would you
> like me to resend this fixed?
Got it...
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
More information about the b43-dev
mailing list