[PATCH] ssb: fail registration for unknown SPROM revision

Larry Finger Larry.Finger at lwfinger.net
Thu Nov 18 12:29:30 EST 2010


On 11/18/2010 11:07 AM, Michael Büsch wrote:
> On Thu, 2010-11-18 at 11:02 -0600, Larry Finger wrote: 
>> On 11/18/2010 10:47 AM, Michael Büsch wrote:
>>> If it would really succeed to initialize the device, this would be a
>>> regulatory issue, because the sprom contains various power amplifier
>>> calibration data. I think it should rather fail and be fixed correctly
>>> instead of incorrectly using rev1 in that case.
>>
>> I agree that it is better to fail than use incorrect power data.
>>
>> Would it be useful if the SPROM data were logged when the revision is crap?
> 
> 
> We need to keep in mind that there will be no new SSB devices.
> It seems pretty much EOL'ed by Broadcom.
> So I'm not sure whether this would be of any use or just random dead
> code.

Good point. When we get the data for the one case we know exists, we will have a
better idea if a special quirk for this case is feasible. Assuming that this is
not the only example of this hardware, then we might limit the breakage from
this patch. At least the random code would be needed and useful in keeping our
maintainer happy, which has a some merit.

Larry



More information about the b43-dev mailing list