[RFC][PATCH] b43: rfkill: use HI enabled bit for all devices

Rafał Miłecki zajec5 at gmail.com
Wed Nov 17 16:02:17 EST 2010


W dniu 17 listopada 2010 21:29 użytkownik Michael Büsch <mb at bu3sch.de> napisał:
> On Wed, 2010-11-17 at 21:23 +0100, Rafał Miłecki wrote:
>> >>  /* Returns TRUE, if the radio is enabled in hardware. */
>> >> -bool b43_is_hw_radio_enabled(struct b43_wldev *dev)
>> >> +inline bool b43_is_hw_radio_enabled(struct b43_wldev *dev)
>> >
>> > inline doesn't make sense here.
>>
>> Err, tip for compiler for optimization? To avoid some JUMPs in generated ASM?
>
> Inline doesn't really work that way. In this case it might generate
> an inline version for callers inside of rfkill.c and an
> always-out-of-line version for other callers.
> If you really want it inline (Which I think isn't really necessary
> as this isn't a fastpath), you'll need to make it static inline
> and put it into rfkill.h

Huh, I got no idea inline works differently for local calls and calls
from other files. That's tricky.

Thanks, I'll send V2.

-- 
Rafał



More information about the b43-dev mailing list