[PATCH] ssb: Clear RETRY_TIMEOUT in PCI Configuration

John W. Linville linville at tuxdriver.com
Tue Nov 16 15:40:25 EST 2010


On Wed, Nov 10, 2010 at 10:52:33PM +0100, Michael Büsch wrote:
> On Wed, 2010-11-10 at 12:37 -0500, John W. Linville wrote: 

> > Does the other patch handle this case (i.e. devices behind SSB->PCI
> > bridge)?  If so, can you explain how?
> 
> Yes. For embedded it goes:
> 
> native-ssb -> pci-core -> pci-bridge module -> wireless ssb
> 
> For PCI it goes:
> 
> native pci bus -> pci-bridge module -> wireless ssb
> 
> So you see that the pci bridge module is the bus glue for all SSB
> based PCI devices. So we do not need the workaround in the pci-core
> driver code. Just in the pci-bridge code (which is 
> drivers/ssb/pcihost_wrapper.c)
> 
> > It looks to me like the code
> > in ssb_pcihost_register is only called for PCI-attached b43 (or b44)
> > devices.
> 
> Yeah. But devices connected to the ssb-pci-core _are_ PCI attached
> devices.
> 
> > Or are you saying the RETRY_TIMEOUT change is inappropriate for a
> > device behind an SSB->PCI bridge?
> 
> No. But we already handle that, because the glue code
> (pcihost_wrapper.c) is used for both types.

Thanks for the explanation!

-- 
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.



More information about the b43-dev mailing list