[PATCH 1/4] b43: N-PHY: update init tables

[Hauke Mehrtens]

On 12/07/2010 09:42 AM, Rafał Miłecki wrote:
> Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
> ---
>  drivers/net/wireless/b43/tables_nphy.c |  212 ++++++++++++++++----------------
>  1 files changed, 106 insertions(+), 106 deletions(-)
> 
> diff --git a/drivers/net/wireless/b43/tables_nphy.c b/drivers/net/wireless/b43/tables_nphy.c
> index d60db07..46f0a7a 100644
> --- a/drivers/net/wireless/b43/tables_nphy.c
> +++ b/drivers/net/wireless/b43/tables_nphy.c
> @@ -28,41 +28,41 @@
>  #include "phy_n.h"
>  
>  static const u8 b43_ntab_adjustpower0[] = {
> -	0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01,
> -	0x02, 0x02, 0x02, 0x02, 0x03, 0x03, 0x03, 0x03,
> -	0x04, 0x04, 0x04, 0x04, 0x05, 0x05, 0x05, 0x05,
> -	0x06, 0x06, 0x06, 0x06, 0x07, 0x07, 0x07, 0x07,
> -	0x08, 0x08, 0x08, 0x08, 0x09, 0x09, 0x09, 0x09,
> -	0x0A, 0x0A, 0x0A, 0x0A, 0x0B, 0x0B, 0x0B, 0x0B,
> -	0x0C, 0x0C, 0x0C, 0x0C, 0x0D, 0x0D, 0x0D, 0x0D,
> -	0x0E, 0x0E, 0x0E, 0x0E, 0x0F, 0x0F, 0x0F, 0x0F,
> -	0x10, 0x10, 0x10, 0x10, 0x11, 0x11, 0x11, 0x11,
> -	0x12, 0x12, 0x12, 0x12, 0x13, 0x13, 0x13, 0x13,
> -	0x14, 0x14, 0x14, 0x14, 0x15, 0x15, 0x15, 0x15,
> -	0x16, 0x16, 0x16, 0x16, 0x17, 0x17, 0x17, 0x17,
> -	0x18, 0x18, 0x18, 0x18, 0x19, 0x19, 0x19, 0x19,
> -	0x1A, 0x1A, 0x1A, 0x1A, 0x1B, 0x1B, 0x1B, 0x1B,
> -	0x1C, 0x1C, 0x1C, 0x1C, 0x1D, 0x1D, 0x1D, 0x1D,
> -	0x1E, 0x1E, 0x1E, 0x1E, 0x1F, 0x1F, 0x1F, 0x1F,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>  };
Why do you have this table when it only contains 0x00? If it is correct
there will be a better way to define such a table.

>  
>  static const u8 b43_ntab_adjustpower1[] = {
> -	0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01,
> -	0x02, 0x02, 0x02, 0x02, 0x03, 0x03, 0x03, 0x03,
> -	0x04, 0x04, 0x04, 0x04, 0x05, 0x05, 0x05, 0x05,
> -	0x06, 0x06, 0x06, 0x06, 0x07, 0x07, 0x07, 0x07,
> -	0x08, 0x08, 0x08, 0x08, 0x09, 0x09, 0x09, 0x09,
> -	0x0A, 0x0A, 0x0A, 0x0A, 0x0B, 0x0B, 0x0B, 0x0B,
> -	0x0C, 0x0C, 0x0C, 0x0C, 0x0D, 0x0D, 0x0D, 0x0D,
> -	0x0E, 0x0E, 0x0E, 0x0E, 0x0F, 0x0F, 0x0F, 0x0F,
> -	0x10, 0x10, 0x10, 0x10, 0x11, 0x11, 0x11, 0x11,
> -	0x12, 0x12, 0x12, 0x12, 0x13, 0x13, 0x13, 0x13,
> -	0x14, 0x14, 0x14, 0x14, 0x15, 0x15, 0x15, 0x15,
> -	0x16, 0x16, 0x16, 0x16, 0x17, 0x17, 0x17, 0x17,
> -	0x18, 0x18, 0x18, 0x18, 0x19, 0x19, 0x19, 0x19,
> -	0x1A, 0x1A, 0x1A, 0x1A, 0x1B, 0x1B, 0x1B, 0x1B,
> -	0x1C, 0x1C, 0x1C, 0x1C, 0x1D, 0x1D, 0x1D, 0x1D,
> -	0x1E, 0x1E, 0x1E, 0x1E, 0x1F, 0x1F, 0x1F, 0x1F,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>  };
Same here.

Hauke