[RFC/RFT] ssb: Attempt to recover from SPROM CRC error

Rafał Miłecki zajec5 at gmail.com
Thu Dec 2 12:59:25 EST 2010


2010/12/2 Larry Finger <Larry.Finger at lwfinger.net>:
> +                       revision = buf[SSB_SPROMSIZE_WORDS_R4 - 1] & 0x00FF;

Should we define macro for that, to do not duplicate code from this part:
sprom_extract(...):
out->revision = in[size - 1] & 0x00FF;
?

I don't vote for any solution, but maybe one should be preferred and
you just didn't notice that? I noone have problem with this liiitle
duplication, ignore me ;)

-- 
Rafał



More information about the b43-dev mailing list