[PATCH 1/2] b43: N-PHY: band width setting with dumb clock control call

[Gábor Stefanik]

On Mon, Aug 23, 2010 at 1:20 AM, Julian Calaby <julian.calaby at gmail.com> wrote:
> Rafal,
>
> Couple of minor style issues, if you're re-submitting.
>
> 2010/8/23 Rafał Miłecki <zajec5 at gmail.com>:
>> Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
>> ---
>>  drivers/net/wireless/b43/phy_common.c |   20 ++++++++++++++++++++
>>  drivers/net/wireless/b43/phy_common.h |   11 +++++++++++
>>  drivers/net/wireless/b43/phy_n.c      |    4 ++--
>>  drivers/net/wireless/b43/phy_n.h      |    1 -
>>  4 files changed, 33 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/b43/phy_common.c b/drivers/net/wireless/b43/phy_common.c
>> index 8f7d7ef..b06e3f0 100644
>> --- a/drivers/net/wireless/b43/phy_common.c
>> +++ b/drivers/net/wireless/b43/phy_common.c
>> @@ -466,3 +466,23 @@ struct b43_c32 b43_cordic(int theta)
>>
>>        return ret;
>>  }
>> +
>> +/* http://bcm-v4.sipsolutions.net/802.11/PHY/ClkCtlClk */
>> +static void b43_clock_control(struct b43_wldev *dev, u32 mode)
>> +{
>> +       ; /* TODO */
>
> You don't need the semicolon here, as I understand it.
>
>> +}
>> +
>> +/* http://bcm-v4.sipsolutions.net/802.11/PHY/BmacBwSet */
>> +void b43_bmac_set_b_width(struct b43_wldev *dev, u8 b_width)
>> +{
>> +       bool fast = dev->phy.forcefastclk;;
>
> Double semicolon - and is it necessary to assign a local variable here?

I agree - don't blindly follow the specs; accessing struct members it
not expensive.

>
>> +       if (!fast)
>> +               b43_clock_control(dev, 0);
>> +       dev->phy.b_width = b_width;
>> +       b43_read32(dev, B43_MMIO_MACCTL); /* flush writes */
>> +       /* TODO: Call PHY BMAC Reset */
>> +       dev->phy.ops->init(dev);

I believe you need to do the whole PHY init, including the common
part; not just the PHY type-specific init. Larry, is this true?

>> +       if (fast)
>> +               b43_clock_control(dev, 2);
>> +}
>
> Thanks,
>
> --
>
> Julian Calaby
>
> Email: julian.calaby at gmail.com
> .Plan: http://sites.google.com/site/juliancalaby/
>



-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)