[PATCH 17/31 v2] build fix: ath_hal_getrtsaggrlimit can be removed here

[Adrian Chadd]

Cool, thanks.

We'll eventually cut this code out. I don't think anyone shipped an
AR7010+AR5418.





Adrian

On 30 March 2013 01:15, Oleksij Rempel <linux at rempel-privat.de> wrote:

> reason for this part of code:
> "AR5416/AR5418 doesn't work with RTS + aggregates longer than 8KiB,
> so the driver has to either limit aggregate sizes to 8KiB or less,
> or disable RTS on longer aggregates. This was fixed in subsequent chips."
>   Adrian Chadd
>
> Signed-off-by: Oleksij Rempel <linux at rempel-privat.de>
> ---
>  target_firmware/wlan/if_owl.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/target_firmware/wlan/if_owl.c b/target_firmware/wlan/if_owl.c
> index e42e6be..4ab16c7 100755
> --- a/target_firmware/wlan/if_owl.c
> +++ b/target_firmware/wlan/if_owl.c
> @@ -339,7 +339,7 @@ static void ath_buf_set_rate(struct ath_softc_tgt *sc,
> struct ath_tx_buf *bf)
>      HAL_11N_RATE_SERIES series[4];
>      a_int32_t i, flags;
>      a_uint8_t rix, cix, rtsctsrate;
> -    a_uint32_t aggr_limit_with_rts;
> +    a_uint32_t aggr_limit_with_rts = 0;
>      a_uint32_t ctsduration = 0;
>      a_int32_t prot_mode = AH_FALSE;
>
> @@ -367,8 +367,10 @@ static void ath_buf_set_rate(struct ath_softc_tgt
> *sc, struct ath_tx_buf *bf)
>             }
>      }
>
> -    ath_hal_getrtsaggrlimit(sc->sc_ah, &aggr_limit_with_rts);
> -
> +    /* TODO: this code is artifact from old chipsets
> +     * AR5416/AR5418, for now we will disable it with
> aggr_limit_with_rts=0
> +     * If some body will complain - we will need to take closer look.
> +     * If not, remove it. (30.03.2013) */
>      if (bf->bf_isaggr && aggr_limit_with_rts &&
>         bf->bf_al > aggr_limit_with_rts) {
>             flags &= ~(HAL_TXDESC_RTSENA);
> --
> 1.8.1.2
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/ath9k_htc_fw/attachments/20130330/8f90fadc/attachment.html>