[PATCH 27/31] build fix: wmi_event and wmi_cmd_rsp should use void *buffer

[Adrian Chadd]

The only reason they'd use UINT8_t here is so you can byte-offset address
buffer.

Is buffer being used for anything except as a copy source/destination
pointer?



Adrian


On 29 March 2013 02:02, Oleksij Rempel <linux at rempel-privat.de> wrote:

> we pass different buffer types to this functions.
> It makes no sense to define some concrect type here
>
> Signed-off-by: Oleksij Rempel <linux at rempel-privat.de>
> ---
>  target_firmware/wlan/if_ath.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/target_firmware/wlan/if_ath.c b/target_firmware/wlan/if_ath.c
> index 022f195..6c5c9e1 100755
> --- a/target_firmware/wlan/if_ath.c
> +++ b/target_firmware/wlan/if_ath.c
> @@ -35,10 +35,8 @@ uint32_t *init_htc_handle = 0;
>  #define UAPSDQ_NUM   9
>  #define CABQ_NUM     8
>
> -void wmi_event(wmi_handle_t handle, WMI_EVENT_ID evt_id, A_UINT8 *buffer,
> a_int32_t Length);
>  void owl_tgt_tx_tasklet(TQUEUE_ARG data);
>  static void ath_tgt_send_beacon(struct ath_softc_tgt *sc,adf_nbuf_t
> bc_hdr,adf_nbuf_t nbuf,HTC_ENDPOINT_ID EndPt);
> -void wmi_cmd_rsp(void *pContext, WMI_COMMAND_ID cmd_id, A_UINT16 SeqNo,
> A_UINT8 *buffer, a_int32_t Length);
>  static void ath_hal_reg_write_tgt(void *Context, A_UINT16 Command,
> A_UINT16 SeqNo, A_UINT8 *data, a_int32_t datalen);
>  extern struct ath_buf * ath_tgt_tx_prepare(struct ath_softc_tgt *sc,
> adf_nbuf_t skb, ath_data_hdr_t *dh);
>  extern void  ath_tgt_send_mgt(struct ath_softc_tgt *sc,adf_nbuf_t
> mgt_hdr, adf_nbuf_t skb,HTC_ENDPOINT_ID EndPt);
> @@ -125,7 +123,7 @@ static void ath_setcurmode(struct ath_softc_tgt *sc,
>  }
>
>  void wmi_event(wmi_handle_t handle, WMI_EVENT_ID evt_id,
> -              A_UINT8 *buffer, a_int32_t Length)
> +              void *buffer, a_int32_t Length)
>  {
>         adf_nbuf_t netbuf = ADF_NBUF_NULL;
>         a_uint8_t *pData;
> @@ -147,7 +145,7 @@ void wmi_event(wmi_handle_t handle, WMI_EVENT_ID
> evt_id,
>  }
>
>  void wmi_cmd_rsp(void *pContext, WMI_COMMAND_ID cmd_id, A_UINT16 SeqNo,
> -                A_UINT8 *buffer, a_int32_t Length)
> +                void *buffer, a_int32_t Length)
>  {
>         adf_nbuf_t netbuf = ADF_NBUF_NULL;
>         A_UINT8 *pData;
> --
> 1.8.1.2
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/ath9k_htc_fw/attachments/20130329/f4090940/attachment-0001.html>