[PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Valo, Kalle kvalo at qca.qualcomm.com
Wed Jun 8 07:46:47 PDT 2016


Prasun Maiti <prasunmaiti87 at gmail.com> writes:

> No. I did not any test for that case.
> This driver create a new wiphy for use with cfg80211 through
> "wiphy_new_nm" api, but in this api, I found that more warnings for
> inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna &&
> !ops->get_antenna);"
> So, warning comes during creation of a new wiphy. That's why It is needed.

I'm confused. Are you really saying that you added a new firmware
command (WMI_SET_ANTENNA_CMDID) to ath6kl but you didn't test it in any
way? How do you know that it works then?

-- 
Kalle Valo


More information about the ath6kl mailing list