[PATCH 4/6] ath6kl: remove unnecessary line continuations
Kalle Valo
kvalo at qca.qualcomm.com
Mon Mar 10 13:26:25 EDT 2014
Joe Perches <joe at perches.com> writes:
> On Sun, 2014-03-09 at 08:57 +0200, Kalle Valo wrote:
>> Fixes checkpatch warning:
>> WARNING: Avoid unnecessary line continuations
>> Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>
> []
>> diff --git a/drivers/net/wireless/ath/ath6kl/core.c b/drivers/net/wireless/ath/ath6kl/core.c
> []
>> @@ -45,8 +45,9 @@ module_param(testmode, uint, 0644);
>> module_param(recovery_enable, uint, 0644);
>> module_param(heart_beat_poll, uint, 0644);
>> MODULE_PARM_DESC(recovery_enable, "Enable recovery from firmware error");
>> -MODULE_PARM_DESC(heart_beat_poll, "Enable fw error detection periodic" \
>> - "polling. This also specifies the polling interval in" \
>> +MODULE_PARM_DESC(heart_beat_poll,
>> + "Enable fw error detection periodic"
>> + "polling. This also specifies the polling interval in"
>> "msecs. Set reocvery_enable for this to be effective");
>
> Couple things:
>
> o There's a missing space between periodic and polling
> o There's a typo of recovery
>
> My suggestion would be to use:
>
> MODULE_PARM_DESC(heart_beat_poll,
> "Enable fw error detection periodic polling in msecs - Also set recovery_enable for this to be effective");
Thanks, I changed it to that.
--
Kalle Valo
More information about the ath6kl
mailing list