[PATCH ath-next] wifi: ath12k: use hal_rx_mon_status for PPDU parse result
Baochen Qiang
baochen.qiang at oss.qualcomm.com
Sun Oct 25 22:56:38 PDT 2026
On 10/16/2026 1:49 PM, Kang Yang wrote:
> ath12k_wifi7_dp_mon_parse_rx_dest() returns enum
> hal_rx_mon_status, but one caller still checks the result against
> HAL_TLV_STATUS_PPDU_DONE.
>
> Use HAL_RX_MON_STATUS_PPDU_DONE instead. This is a cleanup only
> since both values are identical.
>
> Remove the now unused HAL_TLV_STATUS_* defines.
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
>
> Signed-off-by: Kang Yang <kang.yang at oss.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c | 2 +-
> drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h | 5 -----
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c b/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
> index 1e29c13ad66d..7d29b49e8a54 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
> @@ -3214,7 +3214,7 @@ __ath12k_wifi7_dp_mon_process_ring(struct ath12k *ar, int mac_id,
>
> hal_status = ath12k_wifi7_dp_mon_parse_rx_dest(&ar->dp, pmon, skb);
>
> - if (hal_status == HAL_TLV_STATUS_PPDU_DONE) {
> + if (hal_status == HAL_RX_MON_STATUS_PPDU_DONE) {
Not part of this diff, but the same topic:
ath12k_wifi7_dp_mon_srng_process() still declares "u32 hal_status" and
stores the enum hal_rx_mon_status returned by
ath12k_wifi7_dp_mon_rx_parse_mon_status() in it. If you respin for any
reason, better to have it fixed as well.
Reviewed-by: Baochen Qiang <baochen.qiang at oss.qualcomm.com>
More information about the ath12k
mailing list