[PATCH wireless-next 1/5] wifi: cfg80211: Drop unused link stats handling in nl80211_send_station()

[Praneesh P]

On 6/8/2026 12:47 PM, Johannes Berg wrote:
> On Sun, 2026-06-07 at 23:29 +0530, P Praneesh wrote:
>> -static int nl80211_fill_link_station(struct sk_buff *msg,
>> -				     struct cfg80211_registered_device *rdev,
>> -				     struct link_station_info *link_sinfo)
> It's a bit odd that you're dropping this only to reintroduce it in patch
> 4, but I guess it served at least to notice that:
Sure, I'll restructure the series so patch 1 retains 
nl80211_fill_link_station() as-is and only removes
the dead link_stats path from nl80211_send_station(). The function will 
then be modified in
patch 4 where nla_nest_start_noflag -> nla_nest_start is corrected as 
part of introducing the
new per-link send path.
>> -	link_sinfoattr = nla_nest_start_noflag(msg, NL80211_ATTR_STA_INFO);
> all of the nla_nest_start() calls in it really shouldn't have been
> _noflag in the new code at all.
>
> johannes
Understood. NL80211_ATTR_STA_INFO, NL80211_STA_INFO_BSS_PARAM,
NL80211_STA_INFO_TID_STATS, and the per-tid nested attribute are all 
properly-nested
types and must use nla_nest_start(), not nla_nest_start_noflag(). All 
occurrences in new
code will be fixed in v2.

-Praneesh