[PATCH ath-next 5/8] wifi: ath12k: add WBM RX error drop statistics
Jeff Johnson
jeff.johnson at oss.qualcomm.com
Sun Jul 26 09:00:31 PDT 2026
On 7/23/2026 5:54 AM, Pardeep Kaur wrote:
> @@ -1961,7 +1983,8 @@ int ath12k_wifi7_dp_rx_process_wbm_err(struct ath12k_dp *dp,
> device_id = desc_info->device_id;
> partner_dp = ath12k_dp_hw_grp_to_dp(dp_hw_grp, device_id);
> if (unlikely(!partner_dp)) {
> - dev_kfree_skb_any(msdu);
> + ath12k_wifi7_dp_rx_wbm_err_free_skb(dp, msdu,
> + WBM_ERR_DROP_NULL_PRTNR_DP);
>
> /* In any case continuation bit is set
> * in the previous record, cleanup scatter_msdu_list
My review agent flagged that between the blob above and the blob below is the
following code that drops an skb without accounting:
if (err_info.push_reason !=
HAL_REO_DEST_RING_PUSH_REASON_ERR_DETECTED) {
dev_kfree_skb_any(msdu);
continue;
}
Should this be counted?
> @@ -2007,7 +2030,8 @@ int ath12k_wifi7_dp_rx_process_wbm_err(struct ath12k_dp *dp,
> hw_link_id = ath12k_dp_rx_get_msdu_src_link(partner_dp->hal,
> msdu_data);
> if (hw_link_id >= ATH12K_GROUP_MAX_RADIO) {
> - dev_kfree_skb_any(msdu);
> + ath12k_wifi7_dp_rx_wbm_err_free_skb(dp, msdu,
> + WBM_ERR_DROP_INV_HW_ID);
>
> /* In any case continuation bit is set
> * in the previous record, cleanup scatter_msdu_list
More information about the ath12k
mailing list