[PATCH v2] wifi: ath12k: fix scan command endianness on big endian
Jeff Johnson
jeff.johnson at oss.qualcomm.com
Sun Jul 12 14:19:55 PDT 2026
On 7/3/2026 1:18 AM, Baochen Qiang wrote:
> On 7/3/2026 3:35 PM, Alexander Wilhelm wrote:
>> @@ -2795,7 +2799,7 @@ int ath12k_wmi_send_scan_start_cmd(struct ath12k *ar,
>> hint_bssid = ptr;
>> for (i = 0; i < arg->num_hint_bssid; ++i) {
>> hint_bssid->freq_flags =
>> - arg->hint_bssid[i].freq_flags;
>> + cpu_to_le32(arg->hint_bssid[i].freq_flags);
>> ether_addr_copy(&arg->hint_bssid[i].bssid.addr[0],
>> &hint_bssid->bssid.addr[0]);
>
> the src and dst are wrongly swapped, should be
>
> ether_addr_copy(&hint_bssid->bssid.addr[0], &arg->hint_bssid[i].bssid.addr[0]);
>
> However since this is a pre-exising issue and not related to endian handling, not sure if
> we should fix it as well in the same patch.
>
> Jeff, your thought?
Fixing this should be a separate patch since this is an existing issue that is
unrelated to endian handling.
I already have an AI agent fired up to verify the issue so I'll have it
generate the patch.
/jeff
More information about the ath12k
mailing list