[PATCH ath-next] wifi: ath12k: avoid setting 320MHZ support on non 6GHz band
Pablo MARTIN-GOMEZ
pmartin-gomez at freebox.fr
Fri Jan 23 11:21:20 PST 2026
On 23/01/2026 20:08, Johannes Berg wrote:
> On Fri, 2026-01-23 at 19:33 +0100, Pablo MARTIN-GOMEZ wrote:
>>> @@ -4901,8 +4902,14 @@ static void ath12k_wmi_eht_caps_parse(struct ath12k_pdev *pdev, u32 band,
>>> for (i = 0; i < WMI_MAX_EHTCAP_PHY_SIZE; i++)
>>> cap_band->eht_cap_phy_info[i] = le32_to_cpu(cap_phy_info[i]);
>>>
>>> - if (band == NL80211_BAND_6GHZ)
>>> + if (band == NL80211_BAND_6GHZ) {
>>> cap_band->eht_cap_phy_info[0] |= support_320mhz;
>>> + } else {
>>> + phy_cap[0] &= ~IEEE80211_EHT_PHY_CAP0_320MHZ_IN_6GHZ;
>>> + phy_cap[1] &= ~IEEE80211_EHT_PHY_CAP1_BEAMFORMEE_SS_320MHZ_MASK;
>>> + phy_cap[2] &= ~IEEE80211_EHT_PHY_CAP2_SOUNDING_DIM_320MHZ_MASK;
>>> + phy_cap[6] &= ~IEEE80211_EHT_PHY_CAP6_MCS15_SUPP_320MHZ;
>>> + }
>> If you want to clear all 320 MHz fields, you'll also have to clear
>> IEEE80211_EHT_PHY_CAP7_NON_OFDMA_UL_MU_MIMO_320MHZ and
>> IEEE80211_EHT_PHY_CAP7_MU_BEAMFORMER_320MHZ (not sure why it is not done
>> in mac80211)
>>
> This is, effectively, a firmware workaround. It doesn't belong into
> mac80211. All other drivers just have their capabilities managed in the
> driver anyway.
>
> johannes
I wasn't talking about putting this patch in mac80211 (I've seen the
discussion on the patch Nicolas sent on linux-wireless), I'm talking
about the function `ieee80211_put_eht_cap` clearing the Beamformee SS
and Sounding Dimension fields but not the Non-OFDMA UL MU-MIMO and MU
Beamformer fields for each bandwidth.
Pablo
More information about the ath12k
mailing list