[PATCH v2] wifi: ath12k: remove redundant pci_set_drvdata() call
Jeff Johnson
jeff.johnson at oss.qualcomm.com
Thu Jan 15 17:26:49 PST 2026
On Thu, 27 Nov 2025 07:29:37 +0000, Alexander Minchev wrote:
> pci_set_drvdata() is called twice in ath12k_pci_probe() with the
> same pointer. Remove the earlier call so drvdata is set after
> ath12k_base and ath12k_pci initialization is complete.
>
> Having two calls might suggest that drvdata needs to be set early for
> some reason, even though it is not used until after the 'ab' struct
> ath12k_base is fully populated. Even though exact placement is
> not critical, keeping a single pci_set_drvdata() at the end of
> the initialization makes it clearer that drvdata points to a
> fully initialized structure and avoids confusion for future changes.
>
> [...]
Applied, thanks!
[1/1] wifi: ath12k: remove redundant pci_set_drvdata() call
commit: 8fb264d1a0c5b3feae5f492ee2bc2997b71b63e3
Best regards,
--
Jeff Johnson <jeff.johnson at oss.qualcomm.com>
More information about the ath12k
mailing list