[PATCH ath12k-ng v3 6/6] wifi: ath12k: Refactor ath12k_vif structure

[Ripan Deuri]

On 9/30/2025 9:00 AM, Baochen Qiang wrote:
> 
> 
> On 9/29/2025 7:51 PM, Ripan Deuri wrote:
> 
>> @@ -938,15 +944,19 @@ int ath12k_dp_pdev_alloc(struct ath12k_base *ab)
>>  
>>  static void ath12k_dp_update_vdev_search(struct ath12k_link_vif *arvif)
>>  {
>> +	u8 link_id = arvif->link_id;
>> +	struct ath12k_vif *ahvif = arvif->ahvif;
>> +	struct ath12k_dp_link_vif *dp_link_vif = &ahvif->dp_vif.dp_link_vif[link_id];
> 
> nit: consistently use ath12k_dp_vif_to_dp_link_vif()

Addressed in v4.

>> +
>>  	switch (arvif->ahvif->vdev_type) {
>>  	case WMI_VDEV_TYPE_STA:
>> -		arvif->hal_addr_search_flags = HAL_TX_ADDRY_EN;
>> -		arvif->search_type = HAL_TX_ADDR_SEARCH_INDEX;
>> +		dp_link_vif->hal_addr_search_flags = HAL_TX_ADDRY_EN;
>> +		dp_link_vif->search_type = HAL_TX_ADDR_SEARCH_DEFAULT;
>>  		break;
>>  	case WMI_VDEV_TYPE_AP:
>>  	case WMI_VDEV_TYPE_IBSS:
>> -		arvif->hal_addr_search_flags = HAL_TX_ADDRX_EN;
>> -		arvif->search_type = HAL_TX_ADDR_SEARCH_DEFAULT;
>> +		dp_link_vif->hal_addr_search_flags = HAL_TX_ADDRX_EN;
>> +		dp_link_vif->search_type = HAL_TX_ADDR_SEARCH_DEFAULT;
>>  		break;
>>  	case WMI_VDEV_TYPE_MONITOR:
>>  	default:
> 
> [...]
> 
>> @@ -318,12 +318,14 @@ int ath12k_peer_create(struct ath12k *ar, struct ath12k_link_vif *arvif,
>>  		       struct ath12k_wmi_peer_create_arg *arg)
>>  {
>>  	struct ieee80211_vif *vif = ath12k_ahvif_to_vif(arvif->ahvif);
>> +	struct ath12k_vif *ahvif = arvif->ahvif;
>>  	struct ath12k_link_sta *arsta;
>>  	u8 link_id = arvif->link_id;
>>  	struct ath12k_peer *peer;
>>  	struct ath12k_sta *ahsta;
>>  	u16 ml_peer_id;
>>  	int ret;
>> +	struct ath12k_dp_link_vif *dp_link_vif = &ahvif->dp_vif.dp_link_vif[link_id];
> 
> same here, use ath12k_dp_vif_to_dp_link_vif()

Addressed in v4.