[PATCH v2 1/3] wifi: cfg80211: Add support to get EMLSR capabilities of non-AP MLD

[Rameshkumar Sundaram]

On 2/28/2025 6:02 PM, Johannes Berg wrote:
> On Fri, 2025-01-17 at 22:34 +0530, Rameshkumar Sundaram wrote:
>>
>>   include/net/cfg80211.h |  5 +++++
>>   net/wireless/nl80211.c | 12 ++++++++++++
>>   2 files changed, 17 insertions(+)
>>
>> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
>> index 363d7dd2255a..7a80dbf37881 100644
>> --- a/include/net/cfg80211.h
>> +++ b/include/net/cfg80211.h
>> @@ -1756,6 +1756,9 @@ struct cfg80211_ttlm_params {
>>    * @supported_oper_classes_len: number of supported operating classes
>>    * @support_p2p_ps: information if station supports P2P PS mechanism
>>    * @airtime_weight: airtime scheduler weight for this station
>> + * @eml_cap_present: Specifies if EML capabilities field (@eml_cap) is
>> + *	present/updated
>> + * @eml_cap: EML capabilities of this station
>>    * @link_sta_params: link related params.
>>    */
>>   struct station_parameters {
>> @@ -1780,6 +1783,8 @@ struct station_parameters {
>>   	u8 supported_oper_classes_len;
>>   	int support_p2p_ps;
>>   	u16 airtime_weight;
>> +	bool eml_cap_present;
>> +	u16 eml_cap;
>>   	struct link_station_parameters link_sta_params;
>>   };
> 
> OK, I get that this is the minimal change that actually makes this work,
> but it seems a bit lazy to me. Allow me to explain: You don't actually
> _want_ - nor even implement in patch 3 - this changing at any point in
> runtime. OTOH, you _do_ need it to change after the station is
> allocated, because in auth frame exchange you don't have the information
> yet, and that's when the MLD is added.
> 
> So I really think this ought to be accompanied with a change to
> cfg80211_check_station_change() that disallows changing this while the
> station is already associated?
> 

Yes, That's correct thanks for pointing it out, will add changes to 
disallow modification if STA is already associated (i.e. if != 
CFG80211_STA_AP_CLIENT_UNASSOC)

> johannes
> 

-- 
--
Ramesh