[PATCH ath-next v2 2/3] wifi: ath12k: Fix TX status reporting to mac80211 when offload is enabled

Nithyanantham Paramasivam nithyanantham.paramasivam at oss.qualcomm.com
Fri Jul 18 05:56:59 PDT 2025


On Fri, Jul 18, 2025 at 2:45 PM Ping-Ke Shih <pkshih at realtek.com> wrote:
>
> > @@ -578,6 +579,8 @@ ath12k_dp_tx_htt_tx_complete_buf(struct ath12k_base *ab,
> >         struct ath12k *ar;
> >         struct sk_buff *msdu = desc_params->skb;
> >         s32 noise_floor;
> > +       struct ieee80211_tx_status status = { 0 };
>
> With '= {}', no matter how the struct changes, you don't need to change the
> code accordingly.
>

Both ={} and = {0} achieve the same result, right?

> > +       struct ath12k_peer *peer;
> >
> >         skb_cb = ATH12K_SKB_CB(msdu);
> >         info = IEEE80211_SKB_CB(msdu);
>
> [...]
>
> > @@ -805,6 +830,12 @@ static void ath12k_dp_tx_complete_msdu(struct ath12k *ar,
> >         struct ath12k_vif *ahvif;
> >         struct sk_buff *msdu = desc_params->skb;
> >         s32 noise_floor;
> > +       struct ieee80211_tx_status status = { 0 };
> > +       struct ieee80211_rate_status status_rate = { 0 };
>
> ditto.
>
> > +       struct ath12k_peer *peer;
> > +       struct ath12k_link_sta *arsta;
> > +       struct ath12k_sta *ahsta;
> > +       struct rate_info rate;
> >
> >         if (WARN_ON_ONCE(ts->buf_rel_source != HAL_WBM_REL_SRC_MODULE_TQM)) {
> >                 /* Must not happen */
>
>
>



More information about the ath12k mailing list