[PATCH 7/9 RFC] dt-bindings: wireless: ath12k: Add disable-rfkill property

Rob Herring robh at kernel.org
Mon Jul 14 21:02:15 PDT 2025


On Tue, Jul 15, 2025 at 01:26:48AM +0200, Jérôme de Bretagne wrote:
> On Mon. Jul 15, 2025 at 00:33, Dmitry Baryshkov
> <dmitry.baryshkov at oss.qualcomm.com> wrote :
> >
> > On Mon, Jul 14, 2025 at 06:35:43PM +0100, Dale Whinham wrote:
> > > From: Jérôme de Bretagne <jerome.debretagne at gmail.com>
> > >
> > > Document the disable-rfkill property.
> >
> > Why? What does it mean? Why are you describing Linux driver firmware in
> > the DT?
> 
> rfkill should be disabled according to the Surface Pro 11's DSDT.
> 
> https://lore.kernel.org/all/20250113074810.29729-3-quic_lingbok@quicinc.com/
> has added support to read the ACPI bitflag when ACPI is supported.
> 
> The idea was to expose one specific feature (DISABLE_RFKILL_BIT) for
> devices described with a DT, so that the feature can be disabled.

The commit msg should answer all this. That was the purpose of the 
questions.

Assuming it belongs in DT, why is this ath12k specific? Could be for any 
wireless chip...

> > > Signed-off-by: Jérôme de Bretagne <jerome.debretagne at gmail.com>
> > > Signed-off-by: Dale Whinham <daleyo at gmail.com>
> > > ---
> > >  .../devicetree/bindings/net/wireless/qcom,ath12k.yaml          | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> > > index 9e557cb838c7..f15b630fb034 100644
> > > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> > > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> > > @@ -48,6 +48,9 @@ properties:
> > >    vddpcie1p8-supply:
> > >      description: VDD_PCIE_1P8 supply regulator handle
> > >
> > > +  disable-rfkill:
> > > +    type: boolean
> > > +
> > >  required:
> > >    - compatible
> > >    - reg
> > > --
> > > 2.50.1
> > >
> >
> > --
> > With best wishes
> > Dmitry



More information about the ath12k mailing list