[PATCH] wifi: ath12k: Add NULL check to validate tpc_stats

Jeff Johnson jeff.johnson at oss.qualcomm.com
Mon Feb 24 08:03:49 PST 2025


On Fri, 21 Feb 2025 09:42:50 +0530, Roopni Devanathan wrote:
> While processing TPC stats received from firmware, there are chances that
> the tpc_stats might not be filled and the data is not available. This can
> happen under two scenarios. First, when firmware sends a non-zero event
> count before event count 0. When this happens, tpc_stats will be checked
> for data before memory allocation and the tpc_stats will be unavailable.
> Second, when memory allocation failed when event count received is 0 and
> the firmware still sends a non-zero event. When this happens, memory will
> not be allocated for tpc_stats though event count is 0, so when non-zero
> event count is received, tpc_stats will be empty. There are checks to
> validate if tpc_stats variable is filled that are used in two subsequent
> places, but these are placed after tpc_stats is dereference without
> checking if it is NULL or has valid data.
> 
> [...]

Applied, thanks!

[1/1] wifi: ath12k: Add NULL check to validate tpc_stats
      commit: e180a01bf2c4a67db13d70d2d91410a8c6f74be3

Best regards,
-- 
Jeff Johnson <jeff.johnson at oss.qualcomm.com>




More information about the ath12k mailing list