[PATCH v2 1/3] wifi: ath12k: Fix the enabling of REO queue lookup table feature
kernel test robot
lkp at intel.com
Sat Feb 8 10:15:06 PST 2025
Hi Nithyanantham,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 48a62436540224f57013c27519dd2aa3ddd714c9]
url: https://github.com/intel-lab-lkp/linux/commits/Nithyanantham-Paramasivam/wifi-ath12k-Fix-the-enabling-of-REO-queue-lookup-table-feature/20250208-013400
base: 48a62436540224f57013c27519dd2aa3ddd714c9
patch link: https://lore.kernel.org/r/20250207173023.3856217-2-quic_nithp%40quicinc.com
patch subject: [PATCH v2 1/3] wifi: ath12k: Fix the enabling of REO queue lookup table feature
config: i386-randconfig-063-20250208 (https://download.01.org/0day-ci/archive/20250209/202502090206.lIwUMGJF-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250209/202502090206.lIwUMGJF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502090206.lIwUMGJF-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/ath/ath12k/dp.c:1660:30: warning: shift count is negative [-Wshift-count-negative]
1660 | ((dp->reoq_lut.paddr & HAL_REO_QLUT_REG_BASE_ADDR) >> 8));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath12k/hal.h:328:38: note: expanded from macro 'HAL_REO_QLUT_REG_BASE_ADDR'
328 | #define HAL_REO_QLUT_REG_BASE_ADDR GENMASK(39, 8)
| ^~~~~~~~~~~~~~
include/linux/bits.h:35:31: note: expanded from macro 'GENMASK'
35 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~
include/uapi/linux/bits.h:9:19: note: expanded from macro '__GENMASK'
9 | (~_UL(0) >> (__BITS_PER_LONG - 1 - (h))))
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath12k/dp.c:1663:33: warning: shift count is negative [-Wshift-count-negative]
1663 | ((dp->ml_reoq_lut.paddr & HAL_REO_QLUT_REG_BASE_ADDR) >> 8));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath12k/hal.h:328:38: note: expanded from macro 'HAL_REO_QLUT_REG_BASE_ADDR'
328 | #define HAL_REO_QLUT_REG_BASE_ADDR GENMASK(39, 8)
| ^~~~~~~~~~~~~~
include/linux/bits.h:35:31: note: expanded from macro 'GENMASK'
35 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~
include/uapi/linux/bits.h:9:19: note: expanded from macro '__GENMASK'
9 | (~_UL(0) >> (__BITS_PER_LONG - 1 - (h))))
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
vim +1660 drivers/net/wireless/ath/ath12k/dp.c
1628
1629 static int ath12k_dp_reoq_lut_setup(struct ath12k_base *ab)
1630 {
1631 struct ath12k_dp *dp = &ab->dp;
1632 u32 val;
1633 int ret;
1634
1635 if (!ab->hw_params->reoq_lut_support)
1636 return 0;
1637
1638 ret = ath12k_dp_alloc_reoq_lut(ab, &dp->reoq_lut);
1639 if (ret) {
1640 ath12k_warn(ab, "failed to allocate memory for reoq table");
1641 return ret;
1642 }
1643
1644 ret = ath12k_dp_alloc_reoq_lut(ab, &dp->ml_reoq_lut);
1645 if (ret) {
1646 ath12k_warn(ab, "failed to allocate memory for ML reoq table");
1647 dma_free_coherent(ab->dev, dp->reoq_lut.size,
1648 dp->reoq_lut.vaddr_unaligned,
1649 dp->reoq_lut.paddr_unaligned);
1650 dp->reoq_lut.vaddr_unaligned = NULL;
1651 return ret;
1652 }
1653
1654 /* Bits in the register have address [39:8] LUT base address to be
1655 * allocated such that LSBs are assumed to be zero. Also, current
1656 * design supports paddr upto 4 GB max hence it fits in 32 bit register only
1657 */
1658
1659 ath12k_hif_write32(ab, HAL_SEQ_WCSS_UMAC_REO_REG + HAL_REO1_QDESC_LUT_BASE0(ab),
> 1660 ((dp->reoq_lut.paddr & HAL_REO_QLUT_REG_BASE_ADDR) >> 8));
1661
1662 ath12k_hif_write32(ab, HAL_SEQ_WCSS_UMAC_REO_REG + HAL_REO1_QDESC_LUT_BASE1(ab),
1663 ((dp->ml_reoq_lut.paddr & HAL_REO_QLUT_REG_BASE_ADDR) >> 8));
1664
1665 val = ath12k_hif_read32(ab, HAL_SEQ_WCSS_UMAC_REO_REG + HAL_REO1_QDESC_ADDR(ab));
1666
1667 ath12k_hif_write32(ab, HAL_SEQ_WCSS_UMAC_REO_REG + HAL_REO1_QDESC_ADDR(ab),
1668 val | HAL_REO_QDESC_ADDR_READ_LUT_ENABLE);
1669
1670 ath12k_hif_write32(ab, HAL_SEQ_WCSS_UMAC_REO_REG + HAL_REO1_QDESC_MAX_PEERID(ab),
1671 HAL_REO_QDESC_MAX_PEERID);
1672
1673 return 0;
1674 }
1675
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the ath12k
mailing list