[PATCH] wifi: ath12k: report station mode per-chain signal strength
kernel test robot
lkp at intel.com
Fri Feb 7 20:44:04 PST 2025
Hi Lingbo,
kernel test robot noticed the following build warnings:
[auto build test WARNING on d132a72d768bae74d10e6539fcf6522dfdbd1115]
url: https://github.com/intel-lab-lkp/linux/commits/Lingbo-Kong/wifi-ath12k-report-station-mode-per-chain-signal-strength/20250207-151239
base: d132a72d768bae74d10e6539fcf6522dfdbd1115
patch link: https://lore.kernel.org/r/20250207071003.162576-1-quic_lingbok%40quicinc.com
patch subject: [PATCH] wifi: ath12k: report station mode per-chain signal strength
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20250208/202502081250.6rZZ2s6H-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250208/202502081250.6rZZ2s6H-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502081250.6rZZ2s6H-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/net/wireless/ath/ath12k/wmi.c:6:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:8:
In file included from include/linux/cacheflush.h:5:
In file included from arch/x86/include/asm/cacheflush.h:5:
In file included from include/linux/mm.h:2224:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath12k/wmi.c:7550:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
7550 | default:
| ^
drivers/net/wireless/ath/ath12k/wmi.c:7550:2: note: insert 'break;' to avoid fall-through
7550 | default:
| ^
| break;
4 warnings generated.
vim +7550 drivers/net/wireless/ath/ath12k/wmi.c
1715fcabad1648 Lingbo Kong 2025-02-07 7520
79e7b04b5388c1 Lingbo Kong 2025-01-15 7521 static int ath12k_wmi_tlv_fw_stats_parse(struct ath12k_base *ab,
79e7b04b5388c1 Lingbo Kong 2025-01-15 7522 u16 tag, u16 len,
79e7b04b5388c1 Lingbo Kong 2025-01-15 7523 const void *ptr, void *data)
79e7b04b5388c1 Lingbo Kong 2025-01-15 7524 {
79e7b04b5388c1 Lingbo Kong 2025-01-15 7525 struct wmi_tlv_fw_stats_parse *parse = data;
79e7b04b5388c1 Lingbo Kong 2025-01-15 7526 int ret = 0;
79e7b04b5388c1 Lingbo Kong 2025-01-15 7527
79e7b04b5388c1 Lingbo Kong 2025-01-15 7528 switch (tag) {
79e7b04b5388c1 Lingbo Kong 2025-01-15 7529 case WMI_TAG_STATS_EVENT:
79e7b04b5388c1 Lingbo Kong 2025-01-15 7530 parse->ev = ptr;
79e7b04b5388c1 Lingbo Kong 2025-01-15 7531 break;
79e7b04b5388c1 Lingbo Kong 2025-01-15 7532 case WMI_TAG_ARRAY_BYTE:
79e7b04b5388c1 Lingbo Kong 2025-01-15 7533 ret = ath12k_wmi_tlv_fw_stats_data_parse(ab, parse, ptr, len);
79e7b04b5388c1 Lingbo Kong 2025-01-15 7534 break;
1715fcabad1648 Lingbo Kong 2025-02-07 7535 case WMI_TAG_PER_CHAIN_RSSI_STATS:
1715fcabad1648 Lingbo Kong 2025-02-07 7536 parse->rssi = ptr;
1715fcabad1648 Lingbo Kong 2025-02-07 7537 if (le32_to_cpu(parse->ev->stats_id) & WMI_REQUEST_RSSI_PER_CHAIN_STAT)
1715fcabad1648 Lingbo Kong 2025-02-07 7538 parse->rssi_num = le32_to_cpu(parse->rssi->num_per_chain_rssi);
1715fcabad1648 Lingbo Kong 2025-02-07 7539 break;
1715fcabad1648 Lingbo Kong 2025-02-07 7540 case WMI_TAG_ARRAY_STRUCT:
1715fcabad1648 Lingbo Kong 2025-02-07 7541 if (parse->rssi_num && !parse->chain_rssi_done) {
1715fcabad1648 Lingbo Kong 2025-02-07 7542 ret = ath12k_wmi_tlv_iter(ab, ptr, len,
1715fcabad1648 Lingbo Kong 2025-02-07 7543 ath12k_wmi_tlv_rssi_chain_parse,
1715fcabad1648 Lingbo Kong 2025-02-07 7544 parse);
1715fcabad1648 Lingbo Kong 2025-02-07 7545 if (ret)
1715fcabad1648 Lingbo Kong 2025-02-07 7546 return ret;
1715fcabad1648 Lingbo Kong 2025-02-07 7547
1715fcabad1648 Lingbo Kong 2025-02-07 7548 parse->chain_rssi_done = true;
1715fcabad1648 Lingbo Kong 2025-02-07 7549 }
79e7b04b5388c1 Lingbo Kong 2025-01-15 @7550 default:
79e7b04b5388c1 Lingbo Kong 2025-01-15 7551 break;
79e7b04b5388c1 Lingbo Kong 2025-01-15 7552 }
79e7b04b5388c1 Lingbo Kong 2025-01-15 7553 return ret;
79e7b04b5388c1 Lingbo Kong 2025-01-15 7554 }
79e7b04b5388c1 Lingbo Kong 2025-01-15 7555
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the ath12k
mailing list