[PATCH v4 0/3] wifi: ath12k: Support dump PDEV transmit and receive rate HTT stats
Jeff Johnson
jeff.johnson at oss.qualcomm.com
Mon Feb 3 14:32:08 PST 2025
On 2/2/2025 7:36 PM, Aditya Kumar Singh wrote:
> On 2/1/25 06:40, Jeff Johnson wrote:
> [..]
>>
>> pushed to pending, please verify the following edits:
>>
>> patch 1/3:
>> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=d971a54bffcda2421038fd09848b0781244f15c1
>> added 2025 to Qualcomm copyrights in
>> drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
>> drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
>> aligned = in
>> ATH12K_DBG_HTT_EXT_STATS_PDEV_TX_RATE = 9,
>> HTT_STATS_TX_PDEV_RATE_STATS_TAG = 34,
>>
>
> Looks good.
>
>> patch 2/3:
>> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=64cf8cc8f141ad47ca831649f3173fae25c5010b
>> aligned = in
>> ATH12K_DBG_HTT_EXT_STATS_PDEV_RX_RATE = 10,
>> HTT_STATS_RX_PDEV_RATE_STATS_TAG = 35,
>
> I see alignment mismatch in macro
> "ATH12K_HTT_RX_PDEV_STATS_NUM_EXTRA_MCS_COUNTERS". Can that be fixed?
That actually aligns in the code, but looks unaligned in the patch.
The reason is that the leading "+" from the patch pushes the first tab to the
next tab stop.
More information about the ath12k
mailing list