[PATCH next] wifi: ath12k: clean up on error in ath12k_dp_setup()

Baochen Qiang baochen.qiang at oss.qualcomm.com
Thu Dec 18 21:42:15 PST 2025



On 12/18/2025 3:44 PM, Dan Carpenter wrote:
> Destroy the rhash_tbl before returning the error code.

Would be better if the actual problem can be described first.

> 
> Fixes: a88cf5f71adf ("wifi: ath12k: Add hash table for ath12k_dp_link_peer")
> Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>
> ---
>  drivers/net/wireless/ath/ath12k/dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c
> index 9f05eea6695a..ab54c8a84d3e 100644
> --- a/drivers/net/wireless/ath/ath12k/dp.c
> +++ b/drivers/net/wireless/ath/ath12k/dp.c
> @@ -1513,7 +1513,7 @@ static int ath12k_dp_setup(struct ath12k_base *ab)
>  					HAL_WBM_IDLE_LINK, srng, n_link_desc);
>  	if (ret) {
>  		ath12k_warn(ab, "failed to setup link desc: %d\n", ret);
> -		return ret;
> +		goto rhash_destroy;
>  	}
>  
>  	ret = ath12k_dp_cc_init(ab);
However since this is trivial ...

Reviewed-by: Baochen Qiang <baochen.qiang at oss.qualcomm.com>




More information about the ath12k mailing list