[PATCH ath-next v3 2/4] wifi: ath12k: Refactor tx descriptor handling in tx completion handler

Vasanthakumar Thiagarajan vasanthakumar.thiagarajan at oss.qualcomm.com
Thu Apr 10 23:56:05 PDT 2025



On 4/11/2025 11:31 AM, P Praneesh wrote:
> Current code uses mac_id and msdu parameters in ath12k_dp_tx_free_txbuf()
> and ath12k_dp_tx_process_htt_tx_complete(). Since these parameters are
> already encapsulated by struct ath12k_dp_tx_desc, passing them individually
> results in redundant arguments.
> 
> Introduce struct ath12k_tx_desc_params to capture the skb, mac_id, and pass
> it to the corresponding functions. Refactor these functions to use struct
> ath12k_tx_desc_params instead, reducing the number of arguments and improving
> function argument handling efficiency. Additionally, use struct
> ath12k_tx_desc_params in ath12k_dp_tx_htt_tx_complete_buf() and
> ath12k_dp_tx_complete_msdu(), which will be utilized for fetching extended skb
> in a future patch.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> 
> Signed-off-by: P Praneesh <praneesh.p at oss.qualcomm.com>

Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan at oss.qualcomm.com>



More information about the ath12k mailing list