[PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS
Kalle Valo
kvalo at kernel.org
Mon May 13 22:25:11 PDT 2024
Karthikeyan Periyasamy <quic_periyasa at quicinc.com> writes:
> On 5/14/2024 5:01 AM, Jeff Johnson wrote:
>> On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote:
>>> The current value of the MAX_RADIOS define is 3. However, this value is
>>> incorrect as the maximum number of radios supported by all devices does
>>> not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2.
>> Use imperative tense: Therefore, modify ...
>>
>
> Sure, will modify in the next version.
>
>> What is the observed problem, if any, with the current code?
>>
>
> No problem observed but it leads to unnecessary space allocated for
> the hw links in the group and also it gives incorrect perspective to
> the code reader that ath12k support max three radio platform.
Information like this is always good to include in the commit message.
There's less guessing that way.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
More information about the ath12k
mailing list