[PATCH 01/13] wifi: cfg80211: Add provision to advertise multiple radio in one wiphy

[Vasanthakumar Thiagarajan]

On 3/28/2024 1:16 PM, Johannes Berg wrote:
> That's a big set, not sure I can review it all at once :)
> 
> 
>> +struct ieee80211_chans_per_hw {
>> +	u32 n_chans;
>> +	struct ieee80211_channel chans[];
> 
> That should probably use __counted_by() these days.
> 
>> + * @hw_chans: list of the channels supported by every constituent underlying
>> + *	hardware. Drivers abstracting multiple discrete hardware (radio) under
>> + *	one wiphy can advertise the list of channels supported by each physical
>> + *	hardware in this list. Underlying hardware specific channel list can be
>> + *	used while describing interface combination for each of them.
> 
> I'd expect there to be a limit on channels being within a single band on
> a single "hardware"?
> 

There are ath12k hardware supporting multiple band which need to be 
registered under one mac80211_hw/wiphy. This design is to support such 
hardware. I agree, it is adding complexities. I was thinking if this can 
be done in steps , first limiting to single band for a single hardware 
then extending it with multiple bands later but that may bring in 
different set of challenges...


Vasanth