[PATCH v2]wifi: ath12k: Add firmware coredump collection support
Sowmiya Sree Elavalagan
quic_ssreeela at quicinc.com
Sun Mar 24 23:46:29 PDT 2024
On 3/22/2024 9:14 PM, Jeff Johnson wrote:
> On 3/21/2024 10:42 PM, Sowmiya Sree Elavalagan wrote:
>> In case of firmware assert snapshot of firmware memory is essential for
>> debugging. Add firmware coredump collection support for PCI bus.
>> Collect RDDM and firmware paging dumps from MHI and pack them in TLV
>> format and also pack various memory shared during QMI phase in separate
>> TLVs. Add necessary header and share the dumps to user space using dev
>> coredump framework. Coredump collection is disabled by default and can
>> be enabled using menuconfig. Dump collected for a radio is 55 MB
>> approximately.
>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.2.1-00201-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Sowmiya Sree Elavalagan <quic_ssreeela at quicinc.com>
>> ---
>> v2:
>> - Fixed errors shown by ath12k-check
>
> But introduced a new one:
>
> drivers/net/wireless/ath/ath12k/coredump.c:1: Improper SPDX comment style for 'drivers/net/wireless/ath/ath12k/coredump.c', please use '//' instead
> drivers/net/wireless/ath/ath12k/coredump.c:1: Missing or malformed SPDX-License-Identifier tag in line 1
>
> Note that .h use /* */ and .c use // for SPDX comments
>
> Also note that although this applies cleanly to ath-next, it does not apply cleanly to the pending branch, so it will eventually need to be rebased.
>
Hi Jeff,
Sure, will update it in next version.
Thanks,
Sowmiya Sree
More information about the ath12k
mailing list