[PATCH] wifi: ath12k: remove reserve member of wbm completion structure

Jeff Johnson quic_jjohnson at quicinc.com
Fri Mar 1 08:53:14 PST 2024


On 3/1/2024 1:19 AM, quic_tmariyap at quicinc.com wrote:
> From: Thiraviyam Mariyappan <quic_tmariyap at quicinc.com>
> 
> In tx completion, status desc obtained from offsetting the address
> from wbm ring. Having reserved 8 bytes in status desc offsets the
> address twice and read the values from the incorrect address.
> So, removing the reserved 8 bytes from wbm completion structure.

Why not instead remove the addition of HTT_TX_WBM_COMP_STATUS_OFFSET in
ath12k_dp_tx_process_htt_tx_complete()?

That would remove an unnecessary operation in the data path.

> 
> Also this patch is applicable for WCN7850.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Thiraviyam Mariyappan <quic_tmariyap at quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/dp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h
> index eb2dd408e081..d01fc0b0c9a5 100644
> --- a/drivers/net/wireless/ath/ath12k/dp.h
> +++ b/drivers/net/wireless/ath/ath12k/dp.h
> @@ -387,7 +387,6 @@ struct ath12k_dp {
>  #define HTT_TX_WBM_COMP_INFO2_ACK_RSSI		GENMASK(31, 24)
>  
>  struct htt_tx_wbm_completion {
> -	__le32 rsvd0[2];
>  	__le32 info0;
>  	__le32 info1;
>  	__le32 info2;




More information about the ath12k mailing list