[RFC v2 3/7] wifi: cfg80211: extend interface combination check for multi-radio

Felix Fietkau nbd at nbd.name
Thu Jun 6 00:55:38 PDT 2024


On 06.06.24 09:20, Karthikeyan Periyasamy wrote:
> 
> 
> On 6/6/2024 12:01 AM, Felix Fietkau wrote:
>>   
>>   	/*
>>   	 * This is a bit strange, since the iteration used to rely only on
>> @@ -2384,8 +2383,10 @@ int cfg80211_iter_combinations(struct wiphy *wiphy,
>>   	 * cfg80211 already - the only thing not would appear to be any new
>>   	 * interfaces (while being brought up) and channel/radar data.
>>   	 */
>> -	cfg80211_calculate_bi_data(wiphy, params->new_beacon_int,
>> -				   &beacon_int_gcd, &beacon_int_different);
>> +	if (!radio)
>> +			cfg80211_calculate_bi_data(wiphy, params->new_beacon_int,
>> +						   &beacon_int_gcd,
>> +						   &beacon_int_different);
>>   
> 
> Why its avoid for radio specific iface combination ?

Because it iterates over all wdevs within cfg80211. I didn't think this 
was necessary, given that it already excludes MLO wdevs.

- Felix




More information about the ath12k mailing list