[PATCH v6 02/11] wifi: ath12k: fix incorrect logic of calculating vdev_stats_id

Jeff Johnson quic_jjohnson at quicinc.com
Tue Jan 30 08:51:06 PST 2024


On 1/29/2024 8:02 PM, Kang Yang wrote:
> During calculate vdev_stats_id, will compare vdev_stats_id with
> ATH12K_INVAL_VDEV_STATS_ID by '<='. If vdev_stats_id is relatively
> small, then assign ATH12K_INVAL_VDEV_STATS_ID to vdev_stats_id.
> 
> This logic is incorrect. Firstly, should use '>=' instead of '<=' to
> check if this u8 variable exceeds the max valid range.
> 
> Secondly, should use the maximum value as comparison value.
> 
> Correct comparison symbols and use the maximum value
> ATH12K_MAX_VDEV_STATS_ID for comparison.
> 
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

should be blank line between unofficial Tested-on tag and official Fixes tag

> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> 
And no blank line here since all the official tags should be together

> Signed-off-by: Kang Yang <quic_kangyang at quicinc.com>

Kalle can fix the above when he moves into the pending branch

Acked-by: Jeff Johnson <quic_jjohnson at quicinc.com>




More information about the ath12k mailing list