qcn9274 hw2.0 in banana pi r64 - LTSSM read fail

[Janusz Dziedzic]

pon., 29 sty 2024 o 14:04 Kalle Valo <kvalo at kernel.org> napisał(a):
>
> Janusz Dziedzic <janusz.dziedzic at gmail.com> writes:
>
> > I have this card in bpi-r64 board. Need to hash: ath12k_pci_enable_ltssm()
> > While board hang here (next board restart):
> >
> > val = ath12k_pci_read32(ab, PCIE_PCIE_PARF_LTSSM);
> >
> > Is it a 12k bug/MTK pci controller bug?
> > When hash it works correctly.
> >
> > root at OpenWrt:~# lspci -nn
> > 00:00.0 PCI bridge [0604]: MEDIATEK Corp. Device [14c3:3258]
> > 01:00.0 Network controller [0280]: Qualcomm Device [17cb:1109] (rev 01)
> > root at OpenWrt:~#
>
> Sorry, I'm not following you. What do you exactly mean with "hash it"?
>
Have to remove ath12k_pci_enable_ltssm() call.
In other case

ioread32(ab->mem + window_start + PCIE_PCIE_PARF_LTSSM) hang the system.

window_start was 0
PCIE_PCIE_PARF_LTSSM - 0x1e081b0
No idea why this ioread32() fail/hang on bpi-r64

Did smth like this:
static void ath12k_pci_sw_reset(struct ath12k_base *ab, bool power_on)
{
        if (power_on) {
                //ath12k_pci_enable_ltssm(ab);
                ath12k_pci_clear_all_intrs(ab);
                ath12k_pci_set_wlaon_pwr_ctrl(ab);
        }

After that works correctly.


root at OpenWrt:~# dmesg |grep -e ath -e mhi
[  123.056248] ath12k_pci 0000:01:00.0: assign IRQ: got 0
[  123.061704] ath12k_pci 0000:01:00.0: BAR 0: assigned [mem
0x20000000-0x201fffff 64bit]
[  123.069764] ath12k_pci 0000:01:00.0: enabling device (0000 -> 0002)
[  123.076103] ath12k_pci 0000:01:00.0: enabling bus mastering
[  123.089329] ath12k_pci 0000:01:00.0: MSI vectors: 1
[  123.094226] ath12k_pci 0000:01:00.0: Hardware name: qcn9274 hw2.0

   < if ltssm - hang here>

[  123.151406] mhi mhi0: Requested to power ON
[  123.155622] mhi mhi0: Power on setup success
[  123.300815] mhi mhi0: Wait for device to enter SBL or Mission mode
[  123.864188] ath12k_pci 0000:01:00.0: qmi dma allocation failed
(29360128 B type 1), will try later with small size
[  123.893962] ath12k_pci 0000:01:00.0: memory type 10 not supported
[  123.905655] ath12k_pci 0000:01:00.0: chip_id 0x0 chip_family 0xb
board_id 0xff soc_id 0x401a2200
[  123.914441] ath12k_pci 0000:01:00.0: fw_version 0x10098b57
fw_build_timestamp 2022-09-19 18:18 fw_build_id
QC_IMAGE_VERSION_STRING=WLAN.WBE.1.0-02903-QCAHKSWPL_SILICONZ-1
[  125.997541] ath12k_pci 0000:01:00.0: leaving PCI ASPM disabled to
avoid MHI M2 problems
root at OpenWrt:~#

BR