[PATCH v4 10/11] wifi: ath12k: fix incorrect logic of calculating vdev_stats_id

Jeff Johnson quic_jjohnson at quicinc.com
Fri Jan 26 10:23:41 PST 2024


On 1/26/2024 8:56 AM, Jeff Johnson wrote:
> but why isn't this instead using ATH12K_MAX_VDEV_STATS_ID (which is
> currently unused)
> 
> But even the current value for that seems wrong based upon the firmware
> documentation:
>     /**
>      * vdev_stats_id indicates the ID for the REO Rx stats collection
>      * For Beryllium: 0-47 is the valid range and >=48 is invalid
>      * This vdev_stats_id field should be ignored unless the
>      * vdev_stats_id_valid field is non-zero.
>      */

After sending this I realized the value of ATH12K_MAX_VDEV_STATS_ID is
correct, and IMO should be used by the current logic. Use of hex in the
macro vs decimal in the firmware documentation confused me...




More information about the ath12k mailing list