[PATCH] wifi: ath12k: add support for collecting firmware log

[Baochen Qiang]

On 1/17/2024 4:58 PM, Kalle Valo wrote:
> Baochen Qiang <quic_bqiang at quicinc.com> writes:
> 
>> Currently there is no way to collect firmware log because firmware
>> does not send it to host. Also host does not handle WMI_DIAG_EVENTID
>> which is used by firmware to upload firmware log.
>>
>> So add support for it by firstly enabling firmware log upload via a
>> QMI message, and secondly processing WMI DIAG event to expose it to
>> userspace via trace event.
>>
>> This change applies to both WCN7850 and QCN9274.
>>
>> Tested-on: WCN7850 hw2.0 PCI
>> WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
>>
>> Signed-off-by: Baochen Qiang <quic_bqiang at quicinc.com>
> 
> I did some cosmetic changes like reverse xmas tree, debug messages etc.
> 
>> +static int ath12k_qmi_wlanfw_wlan_ini_send(struct ath12k_base *ab, bool enable)
> 
> As enable was always true I removed it. We can add it back later if it's
> needed.
> 
>> +struct qmi_wlanfw_wlan_ini_req_msg_v01 {
>> +	/* Must be set to true if enablefwlog is being passed */
>> +	u8 enablefwlog_valid;
>> +	u8 enablefwlog;
> 
> 'enablefwlog' is really awkward and it's used in several places, why not
> 'enable_fwlog' which is far more readable? I could change that in the
> pending branch.
Yes, Kalle, it is more readable by changing enablefwlog to enable_fwlog.

>