[PATCH 1/2] wifi: ath12k: fix WARN_ON during ath12k_mac_update_vif_chan

[Manish Dharanenthiran]

On 8/8/2023 3:56 PM, Wen Gong wrote:
> On 8/2/2023 10:59 PM, Jeff Johnson wrote:
>> On 8/2/2023 1:58 AM, Manish Dharanenthiran wrote:
>>> Fix WARN_ON() from ath12k_mac_update_vif_chan() if vdev is not up.
>>> Since change_chanctx can be called even before vdev_up.
>>>
>>> Do vdev stop followed by a vdev start in case of vdev is down.
>>>
>>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0-02903-QCAHKSWPL_SILICONZ-1
>>
>> Has this been tested on WCN7850? My understanding is that firmware may 
>> expect vdev down and then vdev restart
>>
> For WCN7850, firmware do not expect vdev down for station vdev type here.
> 
> And this patch only take effect when arvif->is_up is not set,
> 
> it is hard to happen that for MCC station mode.
> 
> Because this function is entered for channel switch for MCC station mode,
> 
> it means station is connected to the AP, then arvif->is_up is set, then 
> this patch not take effect.
> 
> [...]
> 
>>
Thanks Wen for checking this change!

Hi Jeff,

Kindly review the changes and provide your comments.

Regards
Manish Dharanenthiran