[PATCH 2/2] wifi: ath12k: fix undefined behavior with __fls in dp

Harshitha Prem quic_hprem at quicinc.com
Fri Aug 11 02:16:35 PDT 2023



On 8/9/2023 5:47 PM, Johannes Berg wrote:
> On Wed, 2023-08-09 at 09:57 +0530, Harshitha Prem wrote:
>>
>> During the crash, the fragment id of that packet was 0 and
>> __fls returned a junk value. Hence, it was identified that "__fls"
>> would have an undefined behavior if the argument is passed as "0".
>> Therefore, add changes to handle the same.
> 
> Umm. That makes it sound like you are surprised by this behaviour of
> __fls() and expected something else?! Please go read the documentation,
> and then rewrite the commit message. You really shouldn't be surprised
> by this.
> 
> johannes

Thanks Johannes for reviewing the changes. Sure, I will update the 
commit message in next patch version.

Thanks,
Harshitha



More information about the ath12k mailing list