[PATCH] wifi: ath12k: add wait operation for tx management packets for flush from mac80211

[Ramya Gnanasekar]

> -----Original Message-----
> From: Ramya Gnanasekar <rgnanase at qti.qualcomm.com>
> Sent: Monday, April 17, 2023 8:01 PM
> To: Kalle Valo <kvalo at kernel.org>; Ramya Gnanasekar (Temp) (QUIC)
> <quic_rgnanase at quicinc.com>
> Cc: ath12k at lists.infradead.org; linux-wireless at vger.kernel.org; Karthik M
> (QUIC) <quic_karm at quicinc.com>
> Subject: RE: [PATCH] wifi: ath12k: add wait operation for tx management
> packets for flush from mac80211
> 
> > -----Original Message-----
> > From: Kalle Valo <kvalo at kernel.org>
> > Sent: Monday, April 17, 2023 6:26 PM
> > To: Ramya Gnanasekar (Temp) (QUIC) <quic_rgnanase at quicinc.com>
> > Cc: ath12k at lists.infradead.org; linux-wireless at vger.kernel.org;
> > Karthik M
> > (QUIC) <quic_karm at quicinc.com>
> > Subject: Re: [PATCH] wifi: ath12k: add wait operation for tx
> > management packets for flush from mac80211
> >
> > WARNING: This email originated from outside of Qualcomm. Please be
> > wary of any links or attachments, and do not enable macros.
> >
> > Ramya Gnanasekar <quic_rgnanase at quicinc.com> writes:
> >
> > > From: Karthik M <quic_karm at quicinc.com>
> > >
> > > Transmission of management packets are done in a work queue.
> > > Sometimes the workqueue does not finish Tx immediately, then it lead
> > > after the next step of vdev delete finished, it start to send the
> > > management packet to firmware and lead firmware crash.
> > >
> > > ieee80211_set_disassoc() have logic of ieee80211_flush_queues()
> > > after it send_deauth_disassoc() to ath12k, its purpose is make sure
> > > the deauth was actually sent, so it need to change ath12k to match
> > > the purpose of mac80211.
> > >
> > > To address these issues wait for Tx management as well as Tx data packets.
> > >
> > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-
> > QCAHKSWPL_SILICONZ-1
> > >
> > > Signed-off-by: Karthik M <quic_karm at quicinc.com>
> > > Signed-off-by: Ramya Gnanasekar <quic_rgnanase at quicinc.com>
> > >
> > > diff --git a/drivers/net/wireless/ath/ath12k/core.c
> > > b/drivers/net/wireless/ath/ath12k/core.c
> > > index a89e66653f04..499b81cd938e 100644
> >
> > Ramya, how do you submit your patches? Your patches are missing the
> > "---" line which breaks my scripts. I have asked this already before but no reply
> from you:
> >
> > https://lore.kernel.org/all/87edqot8m4.fsf@kernel.org/
> >
> > Please do not ignore my questions. If you continue to do that I will
> > just stop taking patches from you.
> >
> > --
> > https://patchwork.kernel.org/project/linux-wireless/list/
> >
> > https://wireless.wiki.kernel.org/en/developers/documentation/submittin
> > gpatch
> > es
> 
> Hi Kalle,
> 
> I use "git send-email" to send the patches and the patches are generated using
> "git format-patch" command.
> 
> Thanks,
> Ramya

Hi Kalle,

I used "git format-patch -p1" which removed "---" while generating patch. I will correct it by using "git format-patch -1" in future patches.
Also I will resend this patch with right format.

Thanks,
Ramya