[PATCH 06/50] wifi: ath12k: add core.h

Jeff Johnson quic_jjohnson at quicinc.com
Fri Aug 12 17:16:10 PDT 2022


> +struct ath12k_skb_cb {
> +	dma_addr_t paddr;
> +	u8 flags;
> +	u32 cipher;
> +	struct ath12k *ar;
> +	struct ieee80211_vif *vif;
> +	dma_addr_t paddr_ext_desc;
> +} __packed;

Usage of __packed seems incorrect since this is not an ABI buffer, and 
packing will potentially result in some members being unaligned (ath11k 
has struct ath11k_skb_cb packed as well).

Suggest removing __packed and using pahole to find the ideal layout 
since the only concern is that this does not exceed 
IEEE80211_TX_INFO_DRIVER_DATA_SIZE



More information about the ath12k mailing list