[PATCH v2 3/3] wifi: ath11k: fix error path leak in ath11k_tm_cmd_wmi_ftm()

Rameshkumar Sundaram rameshkumar.sundaram at oss.qualcomm.com
Wed May 6 11:15:38 PDT 2026


On 5/6/2026 7:12 PM, Nicolas Escande wrote:
> This is similar to what was fixed by previous patches. We have a to

s/We have a to ../We have a call to .. ?

But no need to resend for this, I think Jeff can fix in pending ?

> ath11k_wmi_cmd_send() which does check the return value, but forgot to
> free the related skb.
> 
> Fixes: b43310e44edc ("wifi: ath11k: factory test mode support")
> Signed-off-by: Nicolas Escande <nico.escande at gmail.com>
> ---
>   drivers/net/wireless/ath/ath11k/testmode.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/testmode.c b/drivers/net/wireless/ath/ath11k/testmode.c
> index a9751ea2a0b7..c72eed358f6d 100644
> --- a/drivers/net/wireless/ath/ath11k/testmode.c
> +++ b/drivers/net/wireless/ath/ath11k/testmode.c
> @@ -457,6 +457,7 @@ static int ath11k_tm_cmd_wmi_ftm(struct ath11k *ar, struct nlattr *tb[])
>   		ret = ath11k_wmi_cmd_send(wmi, skb, cmd_id);
>   		if (ret) {
>   			ath11k_warn(ar->ab, "failed to send wmi ftm command: %d\n", ret);
> +			dev_kfree_skb(skb);
>   			goto out;
>   		}
>   


--
Ramesh



More information about the ath11k mailing list