[PATCH ath-current] wifi: ath11k: avoid bit operation on key flags
Vasanthakumar Thiagarajan
vasanthakumar.thiagarajan at oss.qualcomm.com
Sun Oct 5 08:49:13 PDT 2025
On 10/3/2025 2:51 PM, Rameshkumar Sundaram wrote:
> Bitwise operations with WMI_KEY_PAIRWISE (defined as 0) are ineffective
> and misleading. This results in pairwise key validations added in
> commit 97acb0259cc9 ("wifi: ath11k: fix group data packet drops
> during rekey") to always evaluate false and clear key commands for
> pairwise keys are not honored.
>
> Since firmware supports overwriting the new key without explicitly
> clearing the previous one, there is no visible impact currently.
> However, to restore consistency with the previous behavior and improve
> clarity, replace bitwise operations with direct assignments and
> comparisons for key flags.
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.9.0.1-02146-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.41
>
> Reported-by: Dan Carpenter <dan.carpenter at linaro.org>
> Closes: https://lore.kernel.org/linux-wireless/aLlaetkalDvWcB7b@stanley.mountain
> Fixes: 97acb0259cc9 ("wifi: ath11k: fix group data packet drops during rekey")
> Signed-off-by: Rameshkumar Sundaram <rameshkumar.sundaram at oss.qualcomm.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan at oss.qualcomm.com>
More information about the ath11k
mailing list