[PATCH] Revert "ath11k: clear the keys properly via DISABLE_KEY"

[Vasanthakumar Thiagarajan]

On 6/27/2025 1:01 PM, Nicolas Escande wrote:
> On Tue May 6, 2025 at 11:19 AM CEST, Vasanthakumar Thiagarajan wrote:
>> Hi Nicolas
>>
>> On 5/4/2025 6:06 PM, Nicolas Escande wrote:
>>> On Sat Jan 18, 2025 at 11:29 AM CET, Vasanthakumar Thiagarajan wrote:
>>>> Hi Nicolas,
>>>>
>>>> On 1/18/2025 12:44 AM, Nicolas Escande wrote:
>>>>> This reverts commit 436a4e88659842a7cf634d7cc088c8f2cc94ebf5.
>>>>>
>>>>> This as been reported by multiple people [0] that with this commit,
>>>>> broadcast packets were not being delivered after GTK exchange.
>>>>> Qualcomm seems to have a similar patch [1] confirming the issue.
>>>>>
>>>>
>>>> This will re-open https://www.spinics.net/lists/hostap/msg08921.html
>>>> reported by Sven. The recommended ath firmware ABI during GTK re-keying
>>>> is SET_KEY instead of current DEL_KEY followed by SET_KEY. We are looking
>>>> at other options like some marking by mac80211 for the driver to be able
>>>> to identify if the received DEL_KEY is for re-keying. Also I'm curious
>>>> if roaming between secure and non-secure mode is a critical use case.
>>>> If not, we can probably go ahead with this revert as temporary WAR,
>>>> @Sven?
>>>>
>>>> Vasanth
>>>
>>> Hello,
>>>
>>> Any news on this ?
>>> I would hate for this to sink into oblivion once again given how hard this
>>> affects end users when it does hit.
>>
>> We are working on a driver change w/o reverting the commit, we'll share
>> the patch once complete.
>>
>> Vasanth
> 
> Hello,
> 
> I might be mistaken but I did not see anything posted for that yet, right ?

Patch has not been posted yet. Since the code change does not
look straight forward and the issue is security related it takes
time. This issue is being actively looked into.

Vasanth