[PATCH v2 1/5] wifi: ath11k: refactor transmitted arvif retrieval

[Jeff Johnson]

On 1/18/2025 9:22 PM, aloka.dixit at oss.qualcomm.com wrote:

...

> @@ -1538,7 +1546,7 @@ static int ath11k_mac_setup_bcn_tmpl_ema(struct ath11k_vif *arvif)
>  	u32 params = 0;
>  	u8 i = 0;
>  
> -	tx_arvif = ath11k_vif_to_arvif(arvif->vif->mbssid_tx_vif);
> +	tx_arvif = ath11k_mac_get_tx_arvif(arvif);
>  
>  	beacons = ieee80211_beacon_get_template_ema_list(tx_arvif->ar->hw,
>  							 tx_arvif->vif, 0);
> @@ -1597,7 +1605,7 @@ static int ath11k_mac_setup_bcn_tmpl_mbssid(struct ath11k_vif *arvif)
>  	int ret;
>  
>  	if (vif->mbssid_tx_vif) {

can/should we remove this test since ath11k_mac_get_tx_arvif() already does
this test? note ath11k_control_beaconing() removes the test

> -		tx_arvif = ath11k_vif_to_arvif(vif->mbssid_tx_vif);
> +		tx_arvif = ath11k_mac_get_tx_arvif(arvif);
>  		if (tx_arvif != arvif) {
>  			ar = tx_arvif->ar;
>  			ab = ar->ab;
...
> @@ -1701,9 +1709,7 @@ static void ath11k_control_beaconing(struct ath11k_vif *arvif,
>  
>  	ether_addr_copy(arvif->bssid, info->bssid);
>  
> -	if (arvif->vif->mbssid_tx_vif)
> -		tx_arvif = ath11k_vif_to_arvif(arvif->vif->mbssid_tx_vif);
> -
> +	tx_arvif = ath11k_mac_get_tx_arvif(arvif);
>  	ret = ath11k_wmi_vdev_up(arvif->ar, arvif->vdev_id, arvif->aid,
>  				 arvif->bssid,
>  				 tx_arvif ? tx_arvif->bssid : NULL,